Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singleton instead of bindShared #90

Merged
merged 1 commit into from
Nov 26, 2015
Merged

Use singleton instead of bindShared #90

merged 1 commit into from
Nov 26, 2015

Conversation

sunspikes
Copy link
Contributor

bindShared is deprecated (https:/laravel/framework/blob/5.1/src/Illuminate/Container/Container.php#L289) and removed in Laravel 5.2

florianeckerstorfer pushed a commit that referenced this pull request Nov 26, 2015
Use singleton instead of bindShared
@florianeckerstorfer florianeckerstorfer merged commit 4e06609 into cocur:master Nov 26, 2015
@florianeckerstorfer
Copy link
Member

@sunspikes Could you also provide a PR for the 1.4 branch?

@sunspikes
Copy link
Contributor Author

Done, please see #91 , Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants